Hi, +1 (binding)
I ran several check with a custom script: - clone from git tag + build/test - check license header with apache-rat - check NOTICE and LICENSE files - download the tarball from dist - verify signature and shasum - extract, build and test distribution Good job! PS: I have some failure in tests about my FR local but it's not a blocker: [INFO] Running org.apache.hop.pipeline.DatabaseImpactTest [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.019 s <<< FAILURE! - in org.apache.hop.pipeline.DatabaseImpactTest [ERROR] org.apache.hop.pipeline.DatabaseImpactTest.testGetRow Time elapsed: 0.018 s <<< FAILURE! org.junit.ComparisonFailure: expected:<[Read]> but was:<[Lire]> at org.apache.hop.pipeline.DatabaseImpactTest.testGetRow(DatabaseImpactTest.java:49) regards François [email protected] Le 26/12/2020 à 17:18, Hans Van Akelyen a écrit : > Hi all, > > I am giving this release a +1 > > Did following checks: > - verify signature and hash > - check release tag and commit id > - validate content from tag against archive > - check content notice,license,readme,disclaimer > - ran rat check (we will limit the excludes in next release) > - ran build and tests > - unzipped and opened the software > > Cheers, > Hans > > On Sat, Dec 26, 2020 at 10:48 AM Bart Maertens <[email protected]> > wrote: > >> Hi Hans, >> >> Checks/steps done: >> - downloaded, extracted and built (`mvn clean install`). Hop Gui started >> successfully after build. >> - `mvn clean apache-rat:check` executed successfully >> - `sha512sum apache-hop-0.50-incubating-rc2.tar.gz` returns the correct >> checksum >> >> Very happy to vote +1! >> >> Regards, >> Bart >> >> >> >> >> On Sat, Dec 26, 2020 at 1:01 AM Matt Casters <[email protected] >> .invalid> >> wrote: >> >>> Hi Hans, >>> >>> I downloaded the source tarbal, extracted it successfully and compiled >> with >>> "mvn clean install". I also ran "mvn apache-rat:check" and saw that all >>> was well with the earlier discussed caveats which will be fixed in the >> next >>> release. >>> I noticed the checksum is correct by running "shasum -a 512 >>> apache-hop-0.50-incubating-rc2.tar.gz" and that this is indeed the >> content >>> from the commit/0.50-rc2 tag. >>> >>> So with pleasure I vote >>> >>> +1 >>> >>> Cheers, >>> Matt >>> >>> >>> On Thu, Dec 24, 2020 at 2:50 PM Hans Van Akelyen < >>> [email protected]> >>> wrote: >>> >>>> Hi All, >>>> >>>> After a fruitful discussion about our first release candidate a new >>>> candidate has been created. >>>> Following changes have been applied: >>>> - remove icomoon font >>>> - fix typo in license file >>>> - update readme with instructions to build from archive >>>> - update pom to exclude license folder >>>> >>>> Build instructions can be found in the README included. >>>> >>>> The tag to be voted on is 0.50-rc2 (commit 204da03): >>>> >>>> >> https://github.com/apache/incubator-hop/commit/204da036e545441d36617906263c5a679ce6fbbc >>>> The release files, including signatures, digests, etc. can be found at: >>>> >>>> >> https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-0.50-incubating-rc2/ >>>> The SHA512 Checksum for these artifacts is: >>>> >>>> >> 128ca209f767aa150bdd4a222f7bda15afc01a34533cef4a204322733a99f7496ed1eb66f86a48a13a2723bae195fdf651b5d7608a70a39a1fc7313a8c48f5df >>>> apache-hop-0.50-incubating-rc2.tar.gz >>>> >>>> Release artifacts are signed with the following key: >>>> >> https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x9a8a628dd4f4aa1e >>>> For more information about the contents of this release, see: >>>> https://issues.apache.org/jira/projects/HOP/versions/12349247 >>>> >>>> Please vote on releasing this package as Apache Hop 0.50! >>>> >>>> Due to the holidays we will keep this vote open a bit longer (until the >>> 1st >>>> of January 12 AM CET) >>>> a majority of at least 3 +1 PMC votes are cast. >>>> >>>> [ ] +1 Release this package as Apache Hop 0.50 >>>> [ ] +0 No opinion >>>> [ ] -1 Do not release this package because ... >>>> >>>> Best Regards, >>>> Hans >>>> >>> >>> -- >>> Neo4j Chief Solutions Architect >>> *✉ *[email protected] >>> ☎ +32486972937 >>>
