hansva commented on a change in pull request #889:
URL: https://github.com/apache/incubator-hop/pull/889#discussion_r655368138



##########
File path: 
plugins/actions/pipeline/src/main/java/org/apache/hop/workflow/actions/pipeline/ActionPipeline.java
##########
@@ -624,7 +624,6 @@ public Result execute(Result result, int nr) throws 
HopException {
           pipeline.waitUntilFinished();
 
           if (parentWorkflow.isStopped() || pipeline.getErrors() != 0) {
-            pipeline.stopAll();

Review comment:
       @mattcasters , could you double check this change. (HOP-2954) 
   When debugging I noticed transforms.stopAll() was called twice, once via 
pipeline.execute()
   and then a second time by triggering this line, because everything was 
already stopped it got stuck in a loop.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to