hansva commented on pull request #956: URL: https://github.com/apache/incubator-hop/pull/956#issuecomment-884756571
Hi @sramazzina, Changes look good but a bit too verbose I think. It might be simpler to add an extra method to AbstractMeta.java. So next to `public DatabaseMeta findDatabase( String name )` we could add `public DatabaseMeta findDatabase( String name , IVariables variables)` And do the resolve in there, I think it will overall look cleaner, in a later phase we can deprecate the first method and always use the new one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
