Good idea, junit-vintage-engine makes the migration smoother!
Il giorno dom 9 giu 2024 alle ore 14:19 Hans Van Akelyen < hans.van.akel...@gmail.com> ha scritto: > Hi All, > > I created a PR cleaning up Junit 4 and moving to 5. [1] > To give us a smoother transition to Junit 5 I added the > junit-vintage-engine which allows us to run Junit 4 tests. This will not > force us to having to update all our tests at once. > > I'm also looking at some other things we can do to make our POMs and build > better, more discussions on this soon. > > Cheers, > Hans > > [1] https://github.com/apache/hop/pull/4033 > On May 13, 2024 at 1:39 PM +0200, Hans Van Akelyen < > hans.van.akel...@gmail.com>, wrote: > > Great Idea, this has a +1 from me. > > > > We probably also have to take a look at mockito & powermock. > > > > Cheers, > > Hans > > On 13 May 2024 at 12:45 +0200, Sergio De Lorenzis < > sergio.deloren...@gmail.com>, wrote: > > > Hello Everyone, > > > > > > From my standpoint, it would be beneficial to upgrade to JUnit 5 for > > > several reasons. I'm going to enumerate my personal top three: > > > Wider Range of Possible Assertions: This will improve readability and > allow > > > for more comprehensive tests. > > > Compatibility with Newer Java Versions: Even though there's nothing > > > preventing us from using Java 17 with JUnit 4, I believe it's always > better > > > to pair newer versions of Java with up-to-date libraries. > > > Parameterized Tests and Argument Sources: JUnit 5 provides built-in > support > > > for parameterized tests and multiple sources of arguments, enhancing > our > > > testing capabilities. > > > > > > Looking forward to hearing your thoughts. > > > > > > Best, > > > > > > S. >
