One more thing, you should check the Maven staging works properly. I'm
afraid that the current setting may not work perfectly.

Please try following this doc[1] and provide a staging preview for
org.apache.horaedb:horaedb-proto-internal:jar:2.0.0.

Best,
tison.

[1] https://curator.apache.org/community/releasing-curator

tison <wander4...@gmail.com> 于2024年1月4日周四 16:41写道:
>
> +1 binding
>
> [x] Download links are valid.
> [x] Checksums and signatures.
>
> apache-horaedb-proto-incubating-v2.0.0-src.tar.gz
> gpg: Signature made 四  1/ 4 16:26:39 2024 CST
> gpg:                using RSA key 2CBF6E50D296A228B920F6E8CCEBDB0C26E030F5
> gpg: Good signature from "tanruixiang <tanruixi...@apache.org>" [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg:          There is no indication that the signature belongs to the owner.
> Primary key fingerprint: 2CBF 6E50 D296 A228 B920  F6E8 CCEB DB0C 26E0 30F5
>
> [x] LICENSE/NOTICE files exist
> [x] DISCLAIMER files exist
> [x] No unexpected binary files
> [x] All source files have ASF headers
> [x] Can compile from source
>
> Improvement suggestions that are not blocker:
>
> 1. Currently, the content extracted from tarball is flattened files
> and folders. We can add a top-level folder to improve the experience.
> If you're using git-archive, you may take a look at [1]. Note the
> `--prefix` part.
> 2. grpc-java 1.23.0 doesn't work on MacOS M1 -
>
> [ERROR] ----------
> [ERROR] 1) io.grpc:protoc-gen-grpc-java:exe:osx-aarch_64:1.23.0
> [ERROR]
> [ERROR]   Try downloading the file manually from the project website.
> [ERROR]
> [ERROR]   Then, install it using the command:
> [ERROR]       mvn install:install-file -DgroupId=io.grpc
> -DartifactId=protoc-gen-grpc-java -Dversion=1.23.0
> -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file
> [ERROR]
> [ERROR]   Alternatively, if you host your own repository you can
> deploy the file there:
> [ERROR]       mvn deploy:deploy-file -DgroupId=io.grpc
> -DartifactId=protoc-gen-grpc-java -Dversion=1.23.0
> -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file
> -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR]   Path to dependency:
> [ERROR]    1) org.apache.horaedb:horaedb-proto-internal:jar:2.0.0
> [ERROR]    2) io.grpc:protoc-gen-grpc-java:exe:osx-aarch_64:1.23.0
> [ERROR]
> [ERROR] ----------
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR]   org.apache.horaedb:horaedb-proto-internal:jar:2.0.0
>
> While it's not a blocker, we should think of upgrading protoc & grpc version.
>
> Best,
> tison.
>
> [1] 
> https://github.com/apache/incubator-opendal/blob/46f247c1967018fe49333ff6375d865b362610e6/scripts/release.sh#L65
>
> 谭睿翔(Ruixiang Tan) <tanruixi...@apache.org> 于2024年1月4日周四 16:33写道:
> >
> > Hello, Apache HoraeDB(incubating) Community,
> >
> > This is a call for a vote to release Apache HoraeDB-Proto(incubating)
> > version v2.0.0.
> >
> > The tag to be voted on is v2.0.0-rc.3
> >
> > The release candidate:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/horaedb/horaedb-proto/v2.0.0/
> >
> > Keys to verify the release candidate:
> >
> > https://downloads.apache.org/incubator/horaedb/KEYS
> >
> > Git tag for the release:
> >
> > https://github.com/apache/incubator-horaedb-proto/releases/tag/v2.0.0-rc.3
> >
> > Please download, verify, and test.
> >
> > The VOTE will be open for at least 72 hours and until the necessary
> > number of votes are reached.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Checklist for reference:
> >
> > [ ] Download links are valid.
> > [ ] Checksums and signatures.
> > [ ] LICENSE/NOTICE files exist
> > [ ] No unexpected binary files
> > [ ] All source files have ASF headers
> > [ ] Can compile from source
> >
> > Thanks

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@horaedb.apache.org
For additional commands, e-mail: dev-h...@horaedb.apache.org

Reply via email to