+1 bindings

[x] Download links are valid.
[x] Checksums and signatures.
[x] LICENSE/NOTICE files exist
[x] No unexpected binary files
[x] All source files have ASF headers
[x] Can compile from source

Best wishes,
xikai

tison <wander4...@gmail.com> 于2024年3月8日周五 02:22写道:
>
> +1 binding
>
> I check all the items in the Checklist. With two comments we should
> resolve in the following releases:
>
> 1. Currently, the tarball doesn't have an extra folder layer, so the
> extracted files are messed in the current directory. @tanruixiang
> should ever handle this issue.
> 2. We should give a closer look at the dependencies and their licenses, for
>   2.1 Add license/notice content if we use them in source form, ref [1]
>   2.2 Try to make a DEPENDENCY file like [2]; we'll make it for any binaries
>
> Best,
> tison.
>
> [1] 
> https://github.com/apache/kvrocks/blob/83b3adfdeabec572ec00bb15e93eb6f4000dfb59/NOTICE#L55-L57
> [2] https://github.com/apache/opendal/blob/main/core/DEPENDENCIES.rust.tsv
>
> 任春韶 <chuns...@apache.org> 于2024年3月7日周四 10:53写道:
> >
> > Hello, Apache HoraeDB(incubating) Community,
> >
> > This is a call for a vote to release Apache HoraeDB(incubating)
> > version v2.0.0
> >
> > The tag to be voted on is v2.0.0
> >
> > The release candidate:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/horaedb/horaedb/v2.0.0-rc.2
> >
> > Keys to verify the release candidate:
> >
> > https://downloads.apache.org/incubator/horaedb/KEYS
> >
> > Git tag for the release:
> >
> > https://github.com/apache/incubator-horaedb/releases/tag/v2.0.0-rc.2
> >
> > Please download, verify, and test.
> >
> > The VOTE will be open for at least 72 hours and until the necessary
> > number of votes are reached.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Checklist for reference:
> >
> > [ ] Download links are valid.
> > [ ] Checksums and signatures.
> > [ ] LICENSE/NOTICE files exist
> > [ ] No unexpected binary files
> > [ ] All source files have ASF headers
> > [ ] Can compile from source
> >
> > Thanks
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@horaedb.apache.org
> For additional commands, e-mail: dev-h...@horaedb.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@horaedb.apache.org
For additional commands, e-mail: dev-h...@horaedb.apache.org

Reply via email to