Sorry for the delay; I'm just getting back from vacation and am taking a look now. Do we have a KEYS file? Is there a tag for the release candidate? The tarball doesn't quite match what is in git, so how is the tarball created from the tag? Also are the binary files in htrace-core/src/go/bin intended to be in the tarball? I'll check over the license and notice information as well.
On Sat, Jan 3, 2015 at 12:11 PM, Stack <[email protected]> wrote: > Any chance of a few mentor votes on this thread before I go to the > incubator general list soliciting IPMC votes? > Thanks, > St.Ack > > On Thu, Jan 1, 2015 at 11:38 PM, Colin McCabe <[email protected]> > wrote: > > > +1. Thanks for putting this together, st.ack. > > > > C. > > On Dec 31, 2014 2:44 PM, "Colin McCabe" <[email protected]> wrote: > > > > > I verified the signature, untarred, ran mvn test with no problems. I > > > did see that we are leaking a few jackson classes on to the CLASSPATH > > > in htrace-core: > > > > > > jar tvf ./htrace-core/target/htrace-core-3.1.0.jar > > > .... > > > 2487 Wed Dec 31 14:29:18 PST 2014 > > > > org/apache/htrace/fasterxml/jackson/core/util/MinimalPrettyPrinter.class > > > 8621 Wed Dec 31 14:29:18 PST 2014 > > > org/apache/htrace/fasterxml/jackson/core/util/TextBuffer.class > > > 6419 Wed Dec 31 14:29:18 PST 2014 > > > org/apache/htrace/fasterxml/jackson/core/util/VersionUtil.class > > > 0 Wed Dec 31 14:29:18 PST 2014 com/ > > > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/ > > > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/ > > > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/databind/ > > > 801 Wed Dec 31 14:29:18 PST 2014 > > > com/fasterxml/jackson/databind/AbstractTypeResolver.class > > > 1506 Wed Dec 31 14:29:18 PST 2014 > > > > > > > > > com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty$Type.class > > > ... > > > > > > This could potentially be an issue because some of our users want to > > > use a different version of jackson than what we're using. I posted a > > > fix at https://issues.apache.org/jira/browse/HTRACE-46. Not sure if > > > this is worth spinning a new RC over. > > > > > > Colin > > > > > > On Wed, Dec 31, 2014 at 1:32 PM, Elliott Clark <[email protected]> > > wrote: > > > > +1 > > > > Verified sig. > > > > un-tar'd the src tar. > > > > Verified that all tests pass > > > > mvn package creates go binaries. > > > > Those binaries run and listen on a port > > > > maven repository looks good and has the needed jars. > > > > > > > > On Wed, Dec 31, 2014 at 1:01 PM, Stack <[email protected]> wrote: > > > > > > > >> I've posted our fifth release candidate here (Thanks all for finding > > > issues > > > >> in previous RCs): > > > >> > > > >> http://people.apache.org/~stack/htrace-3.1.0RC4/ > > > >> > > > >> Maven artifacts are available here: > > > >> > > > >> > > > > https://repository.apache.org/content/repositories/orgapachehtrace-1006 > > > >> > > > >> RC4 has 4 fixes beyond RC3. > > > >> > > > >> It is a src-only tarball for now. Later we can add binary bundles to > > our > > > >> release after we have better sense of what we as a project would > like > > to > > > >> deliver. > > > >> > > > >> This release is mainly a change of packaging from org.htrace to > > > >> org.apache.htrace to suit our new home here in Apache Incubator but > it > > > does > > > >> also includes 32 resolved issues [1] including the beginnings of an > > > htrace > > > >> daemon whose intent is to make it so there is a low barrier > collecting > > > >> cluster traces as well as a new flume receiver. > > > >> > > > >> Beware that Apache Incubator, org.apache.htrace is not compatible > with > > > its > > > >> former self, org.htrace: the package name has changed but so has the > > > JSON > > > >> serialization format. > > > >> > > > >> Shall we make this release candidate our first incubator release? > > > >> > > > >> Lets keep the vote period short (We'll have to run another vote over > > in > > > >> incubator general after this one if I understand the process > > properly). > > > >> > > > >> Please vote +1/0/-1 by Friday, January 2nd, 2015. > > > >> > > > >> Thanks, > > > >> St.Ack > > > >> > > > >> 1. > > > >> > > > >> > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC > > > >> > > > > > >
