Thanks Billie for the early +1. On the inclusion of generated files, I filed HTRACE-81 I don't think it enough to sink RC either. Will fix for next release.
Thanks, St.Ack On Thu, Jan 15, 2015 at 5:27 PM, Billie Rinaldi <[email protected]> wrote: > +1 > signature and checksums are good > mvn clean install assembly:single runs successfully including tests > disclaimer is there and tarball has incubating in the name > all bundled dependencies appear in license and notice > license headers are good > no binaries in source tarball > > The only unusual thing I noticed was that there are some generated sources > in this resource directory that were not present when I built the tarball > myself (listed below). Given that they are generated sources with license > headers and our LICENSE file covers the content in them, maybe it's not a > reason to fail the RC? I'm not sure how these got there, though; they go > away with 'mvn clean'. > > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__app.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__mock.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__models__span.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__setup.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__views__search.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__views__span.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/catalog.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/index.html.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap-theme.css.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap-theme.css.map.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap-theme.min.css.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap.css.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap.css.map.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap.min.css.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__js__bootstrap.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__js__bootstrap.min.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__js__npm.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__css__main.css.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__js__backbone-1.1.2.min.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__js__jquery-2.1.3.min.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__js__underscore-1.7.0.min.js.go > > htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/nested__nested.html.go > > On Thu, Jan 15, 2015 at 11:41 AM, Stack <[email protected]> wrote: > > > I've posted the tenth htrace-3.1.0 release candidate here: > > > > http://people.apache.org/~stack/htrace-3.1.0-incubatingRC9/ > > > > (Our RCs are zero based so RC9 is the tenth RC) > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachehtrace-1014 > > > > The only changes from RC8 are changes to address hawkeye Billies > comments. > > > > The release is a src-only tarball for now. Later we can add binary > bundles > > to our release after we have better sense of what we as a project would > > like to deliver. > > > > This release is mainly a change of packaging from org.htrace to > > org.apache.htrace to suit our new home here in Apache Incubator but it > does > > also includes 44 resolved issues [1] including the beginnings of an > htrace > > daemon whose intent is to make it so there is a low barrier collecting > > cluster traces as well as a new flume receiver. > > > > Beware that Apache Incubator, org.apache.htrace is not compatible with > its > > former self, org.htrace: the package name has changed but so has the JSON > > serialization format. See README.md for a few notes on how to migrate. > > > > Shall we make this release candidate our first incubator release? > > > > Lets keep the vote period short (We'll have to run another vote over in > > incubator general after this one if I understand the process properly). > > > > Please vote +1/0/-1 by Friday, January 15th, 2015. > > > > Thanks, > > St.Ack > > > > 1. > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC > > >
