On Mon, Jan 19, 2015 at 10:30 PM, Stack <[email protected]> wrote: > Here is help for htrace: > > kalashnikov-17:go stack$ ./build/htrace --help > usage: htrace [<flags>] <command> [<flags>] [<args> ...] > > The HTrace tracing utility. > > Flags: > --help Show help. > --addr=0.0.0.0:9095 Server address. > > Commands: > help [<command>] > Show help for a command. > > version > Print the version of this program. > > serverInfo > Print information retrieved from an htraced server. > > findSpan --id=ID > Print information about a trace span with a given ID. > > findChildren --id=ID [<flags>] > Print out the span IDs that are children of a given span ID. > > writeSpans --json=JSON > Write spans to the server in JSON form. > > > What is a little odd to me is that required arguments are done as 'options' > or 'flags'. For example, findSpan requires that you pass an id but the id > is passed with the '--id=ID' format. Shouldn't it be 'findSpan ID' with > flags and options passed with '--...' format? >
Good idea. We could make 'ID' the first positional argument. The argument parsing library we're using supports that pretty easily, I think. Open a JIRA? > When I start htraced, it should print version and the port it is listening > on. > > Yeah > It looks like the serverInfo is gotten by doing a GET on /server/info yet I > write spans at /writeSpans. Shouldn't the span writing and seaching be > under a subdir at /spans: e.g. to write spans you'd do /spans/write and to > find you'd do /spans/find ? > I think the current paradigm for "find" is GET /$SPAN_ID, where SPAN_ID is the hex ID of the span. I'd be fine with moving that to "GET /spans/$SPAN_ID". Then we could move writing spans to "PUT /spans/write" for consistency. When I send spans to htraced, it logs each it receives. Can I turn this > off? Can I turn on logging even more info like the total REST request > (optionally)? > > I've been looking at making htraced logging a big more configurable. Well, ok... configurable at all :) I should have something up on that soon. Colin > St.Ack >
