agree, there are no binary files, so the extra artifacts are not a release blocker, would remove for the next release.
+1 for this rc from me -Jake On Thu, May 7, 2015 at 1:33 AM, Lewis John Mcgibbney < lewis.mcgibb...@gmail.com> wrote: > I would say no, don't roll a new RC. > If there is a way to ensure that generated files have ALv2.0 headers moving > forward and committed to trunk then that would be my advice. > Good job with RC. > +1 from me > > On Wednesday, May 6, 2015, Abraham Elmahrek <a...@cloudera.com> wrote: > > > Lewis, > > > > These are third party packages and a generated file. The JS dependencies > > are listed in LICENSE.txt. I don't see licenses for > > dependency-reduced-pom.xml in general... but I think it might be > generated > > by the maven shading plugin. It looks like some of these generated files > > made it into the source tarball. Do you guys think it's worth spinning a > > new RC for this? > > > > -Abe > > > > On Wed, May 6, 2015 at 6:05 PM, Lewis John Mcgibbney < > > lewis.mcgibb...@gmail.com <javascript:;>> wrote: > > > > > Hi Folks, > > > I ran DRAT over the codebase > > > > > > Notes Binaries Archives Standards Apache Generated Unknown 0 0 0 120 > > 83 > > > 0 > > > 28 > > > > > > 28 unknown licenses flagged up > > > > > > Upon further investigation these were > > > > > > Unapproved licenses: > > > > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/backbone-1.1.2.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/backbone.marionette-2.4.1.min.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/backbone.paginator-2.0.2.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/backgrid-0.3.5.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/backgrid-paginator-0.3.5.js > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/bootstrap.js > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/bootstrap.min.js > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/d3-3.5.5.js > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/d3.min.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/jquery-2.1.3.min.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/moment-2.9.0.min.js > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/npm.js > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/rome.js > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/rome.min.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/rome.standalone.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/rome.standalone.min.js > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456935/input/underscore-1.7.0.js > > > > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/backgrid-0.3.5.min.css > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/backgrid-paginator-0.3.5.min.css > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/bootstrap-theme.css > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/bootstrap-theme.min.css > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/bootstrap.css > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/bootstrap.min.css > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/rome.css > > > /usr/local/drat/deploy/data/jobs/rat/1430960457357/input/rome.min.css > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960456828/input/SpanProtos.java > > > > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457162/input/dependency-reduced-pom.xml > > > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1430960457162/input/dependency-reduced-pom.xml_05062015_1800 > > > > > > If we can clarify the above then I am +1 to the release. > > > > > > There's nothing more I can add over and above what has been stated by > > > others. > > > SIGS check > > > Builds and Tests in native check > > > Nice release candidate. > > > Thanks > > > Lewis > > > > > > > > > On Thu, Apr 30, 2015 at 9:16 PM, Abraham Elmahrek <a...@apache.org > > <javascript:;>> wrote: > > > > > > > I've the second release candidate here: > > > > > > > > *http://people.apache.org/~abe/htrace/releases/3.2.0/rc1/ > > > > <http://people.apache.org/~abe/htrace/releases/3.2.0/rc1/>* > > > > > > > > The jars have been staged here: > > > > > > > > * > > > > https://repository.apache.org/content/repositories/orgapachehtrace-1016 > > > > < > > https://repository.apache.org/content/repositories/orgapachehtrace-1016 > > > >* > > > > > > > > This release improves the Java client with better error checking and > > > > setting parents in a span after the span is created. Also, some > issues > > in > > > > the local file span receiver are fixed and work has started on a new > > > C/C++ > > > > native client. > > > > > > > > Please vote +1/0/-1 by Friday, May 7th, 2015. > > > > > > > > Thanks, > > > > Abe > > > > > > > > 1. > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%203.2.0%20AND%20project%20%3D%20HTRACE%20AND%20status%20%3D%20Resolved%20ORDER%20BY%20priority%20DESC > > > > > > > > > > > > Release Notes - HTrace - Version 3.2.0 > > > > > > > > ** Sub-task > > > > * [HTRACE-44] - Add htraced web UI search page skeleton > > > > * [HTRACE-45] - Add Span details page skeleton > > > > * [HTRACE-75] - UI should query htraced > > > > * [HTRACE-76] - Search page: Add +/- filters to search control > > > > * [HTRACE-77] - htraced gui: add pagination to the search page. > > > > * [HTRACE-78] - Search page: Enhance begin time and end time > > > selection > > > > widget > > > > * [HTRACE-79] - Search page: Make list more tabular with sorting > on > > > > front end > > > > * [HTRACE-108] - Search Page: Use server side pagination > > > > * [HTRACE-121] - Details page: Graph parents and children > > > > * [HTRACE-131] - Port spans.js in htrace-hbase to htraced > > > > * [HTRACE-134] - Port front end to marionette JS > > > > * [HTRACE-142] - Details page: Update graph > > > > * [HTRACE-146] - Search page: Remove client-side sorting and > > improve > > > > pagination > > > > > > > > ** Bug > > > > * [HTRACE-32] - Change span timeline annotations map to be a > > > > map<string, string> > > > > * [HTRACE-37] - htraced: serve index.html if the root URL was > given > > > > * [HTRACE-47] - Add Content-Type header in REST server > > > > * [HTRACE-48] - use -L 1 in format.sh to make it work on macosx > > > > * [HTRACE-52] - FIgure out content-type handling in JSON API > > > > * [HTRACE-55] - Add Clean command to htrace go > > > > * [HTRACE-57] - Fix LocalFileSpanReceiver to avoid adding > > irrelevant > > > > wrapper object > > > > * [HTRACE-68] - Clean up LocalFileSpanReceiver and > > > SpanReceiverBuilder > > > > a bit > > > > * [HTRACE-71] - format.sh: only format src/ directory > > > > * [HTRACE-90] - Remove Guava and shade other depdendencies in > > HTrace > > > > subprojects > > > > * [HTRACE-93] - Add null check to SamplerBuilder > > > > * [HTRACE-97] - Support both -D and --D when specifying conf vars > > on > > > > the command-line > > > > * [HTRACE-98] - Web Server should use PrefixHandler > > > > * [HTRACE-99] - log.go fails to create new log files > > > > * [HTRACE-100] - htraced: put query parameters in the URL, not in > > the > > > > GET request body > > > > * [HTRACE-101] - Add better error-checking to Java HTrace client > > > > * [HTRACE-103] - Reset unclosed spans after TestBadClient > > > > * [HTRACE-107] - Support for Greater Than operator in htraced > > > > * [HTRACE-109] - fix TestHTracedRESTReceiver unit test failures > > > > * [HTRACE-110] - Fix rat check failure due to > > > > dependency-reduced-pom.xml in htrace-hbase > > > > * [HTRACE-111] - HTrace Java client API fixes for 3.2 > > > > * [HTRACE-112] - Fix LocalFileSpanReceiver to avoid BG thread and > > > > problems around close() > > > > * [HTRACE-115] - The htraced datastore should use uint64 for span > > ids > > > > rather than int64 > > > > * [HTRACE-116] - htraced's data.store.clear option does not work > > > > * [HTRACE-117] - graph.go: sort children array to get > deterministic > > > > output > > > > * [HTRACE-118] - Java API: support setting the parents of a span > > > after > > > > the span is created > > > > * [HTRACE-119] - detach of NullScope singleton should not fail > > > > * [HTRACE-123] - fix graphviz functionality in the htrace command > > > > * [HTRACE-126] - BUILDING.txt should not say that godep is > > required, > > > > because we auto-install godep > > > > * [HTRACE-127] - fix ./build/htrace dumpAll > > > > * [HTRACE-128] - RAT check hangs on files under > > > > htrace-core/src/web/lib/rome-2.1.0 > > > > * [HTRACE-132] - Trace#startSpan(String, TraceInfo) must not > create > > > > spans with spanId == 0 > > > > * [HTRACE-133] - HTracedRESTReceiver drops spans when close() is > > > called > > > > * [HTRACE-140] - Web UI of htraced causes high CPU usage if > search > > > > result is empty > > > > * [HTRACE-141] - Fix nits of swimlane view of htraced Web UI > > > > * [HTRACE-148] - Add deserialization utility method to MilliSpan > > for > > > > testing outside of htrace-core > > > > * [HTRACE-151] - htrace-core, htrace-htraced: Use shaded import > > paths > > > > * [HTRACE-152] - Fix TestHTracedRESTReceiver > > > > com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException > > > > * [HTRACE-158] - htraced: add TraceEnabled, DebugEnabled, etc. > > > > functions to log.go > > > > * [HTRACE-161] - C client style.txt should be excluded from rat > > check > > > > * [HTRACE-163] - Remove bin directory and add to maven clean > > > > > > > > ** Improvement > > > > * [HTRACE-30] - Add writeSpan REST verb to htraced > > > > * [HTRACE-33] - Add getUniqueLocalTraceFileName to > > > > LocalFileSpanReceiver > > > > * [HTRACE-50] - Clean up build warnings > > > > * [HTRACE-53] - Move client code into client.go, add unit tests > for > > > > bin/htrace command and htraced REST API > > > > * [HTRACE-82] - Add profile to pom to use maven-assembly-plugin > for > > > > both src tarball and fat jars > > > > * [HTRACE-91] - Add usage to htraced, fix htrace usage and > support > > > > HTRACED_CONF_DIR > > > > * [HTRACE-104] - Add more capabilities to the htrace command > > > > * [HTRACE-113] - Add more log4j messages to htrace > SamplerBuilder, > > > > SpanReceiverBuilder, etc. > > > > * [HTRACE-120] - UI: Track search history via URL hash > > > > * [HTRACE-122] - Remove bundler > > > > * [HTRACE-125] - htraced: log when htraced terminates on a > signal, > > > and > > > > optionally log configuration when starting up > > > > * [HTRACE-137] - Add Begin, processId, duration fields to htrace > > > search > > > > GUI > > > > * [HTRACE-144] - Include IP address in span process description > > > > * [HTRACE-149] - htraced: remove unused resource/ directory > > > > * [HTRACE-154] - Move go and web to htrace-htraced > > > > * [HTRACE-155] - Remove references to 'resource' directory from > the > > > > .gitignore > > > > > > > > ** New Feature > > > > * [HTRACE-51] - htraced java REST client (a.k.a java SpanReceiver > > for > > > > htraced) > > > > * [HTRACE-88] - Add REST query API to htraced > > > > * [HTRACE-89] - htraced: add log levels, writing to log files > > > > * [HTRACE-106] - htrace: add C / C++ native client > > > > * [HTRACE-150] - htraced: add HRPC endpoint for writeSpans > > > > > > > > > > > > > > > > -- > > > *Lewis* > > > > > > > > -- > *Lewis* >
