Hi Colin, Thanks for filing issues. +1 to release this release candidate. Lewis
On Thu, Feb 4, 2016 at 10:45 AM, < [email protected]> wrote: > > Thanks for looking at this, Lewis. > > On Tue, Feb 2, 2016 at 6:25 PM, Lewis John Mcgibbney > <[email protected]> wrote: > > Hi Colin, > > > > Signatures Good > > Aggregated results of running DRAT over the release candidate > > > > Notes Binaries Archives Standards Apache Generated Unknown > > 0 0 0 142 118 0 15 > > Unapproved licenses include > > > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap-theme.css > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap-theme.min.css > > /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap.css > > > /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap.min.css > > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/backbone-1.1.2.js > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/bootstrap.js > > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/bootstrap.min.js > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/d3.min.js > > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/jquery-2.1.4.js > > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/moment-2.10.3.js > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/npm.js > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/underscore-1.7.0.js > > > /usr/local/drat/deploy/data/jobs/rat/1454465688785/input/SpanProtos.java > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml_02022016_1814 > > > > I understand that the .css and .js files above are covered in LICENSE at > > the bottom however we need to address the following files > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465688785/input/SpanProtos.java > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml > > > > > /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml_02022016_1814 > > Hmm. I think we talked about SpanProtos.java, > dependency-reduced-pom.xml, etc. during the previous release and > concluded that they are generated files, and hence exempt from the > license requirement according to > > http://incubator.apache.org/guides/releasemanagement.html#notes-license-headers > > > > > NOTICE includes > > Copyright 2015 The Apache Software Foundation > > This should be > > Copyright 2016 The Apache Software Foundation > > > > OK > > > There seems to be a bit on confusion between instructions for Building > the > > code. We have the note in README.md and then a separate note within > > BUILDING.txt. We should probably resolve this and include them both in > > README.md > > > > OK, I created HTRACE-342 to fix this. > > > Build and tests pass fine. > > > > Typically the absence of the license header in the above files would be a > > -1 from me. I will wait to see how others review the candidate before > > VOTE'ing. > > Good job putting this together. > > Thanks > > best, > Colin > >
