On Thu, Aug 23, 2001 at 10:42:16PM -0700, Doug MacEachern wrote:
> > IMHO, the call to ssl_util_thread_setup should be moved to
> > ssl_init_Child and even potentially surrounded by
> > #if APR_HAS_THREADS. -- justin
>
> why child init rather than module init?
> i did turn off the locking unless the mpm is threaded. isn't it possible
> that APR_HAS_THREADS is true even though the mpm is not threaded?
Yes, you are correct here. I didn't think about the mpm query
facilities. =)
It should be in child init rather than module init so that the locks are
created per child not globally (via post_config hook). That is the
tradeoff by having APR_INTRAPROCESS.
If you created the locks as INTRAPROCESS before fork()ing new children,
would each children's copy of the lock be isolated? Maybe. If so,
then the post_config hook works, but I think child_init makes a bit
more sense. But, that's me. -- justin
