[dropped dev@subversion]
> From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]]
> Sent: 10 September 2001 14:37
> From: "Sander Striker" <[EMAIL PROTECTED]>
> Sent: Monday, September 10, 2001 3:24 AM
>
>
> > >> I've looked into this slightly, and the underlying problem is that
> > >> ap_merge_per_dir_configs finds a previous cached merge (for /?) and
> > >> tries to use it but the entry for mod_ssl is NULL. The URL, btw, is
> > >> /svn.
> > >
> > > This is very, very odd. Would someone please post the svn
> > > create/merge dir config
> > > code, just in case it's clobbering a sibling?
> >
> > #define INHERIT_VALUE(parent, child, field) \
> > ((child)->field ? (child)->field : (parent)->field)
> >
> > Looks ok to me...
>
> Looks OK to me too...
>
> Who wants to toss together a patch to pull all the helper code
> from mod_ssl,
> change it from eastern to western European, and drop it back in the right
> place (AP_ decorated) such as ap_config.h?
>
> If _we_ need these sort of helpers...
>
> #define cfgMerge(el,unset) new->el = (add->el == (unset)) ?
> base->el : add->el
> #define cfgMergeArray(el) new->el = apr_array_append(p,
> add->el, base->el)
> #define cfgMergeTable(el) new->el = apr_table_overlay(p,
> add->el, base->el)
> #define cfgMergeCtx(el) new->el = apr_table_overlay(p,
> add->el, base->el)
> #define cfgMergeString(el) cfgMerge(el, NULL)
> #define cfgMergeBool(el) cfgMerge(el, UNSET)
> #define cfgMergeInt(el) cfgMerge(el, UNSET)
>
> then apparently (as your example shows) the rest of the world
> needs these as well.
I don't mind putting a patch together that does this (and to use
it in all core modules). I would appreciate suggestions for the
final names though (naming isn't my strong side).
AP_CFG_MERGE
AP_CFG_MERGE_ARRAY
...
?
> Bill
Sander
