On Mon, Sep 10, 2001 at 09:23:59AM -0500, William A. Rowe, Jr. wrote:
> From: "Ryan Bloom" <[EMAIL PROTECTED]>
> Sent: Monday, September 10, 2001 8:39 AM
>
> > > I don't mind putting a patch together that does this (and to use
> > > it in all core modules). I would appreciate suggestions for the
> > > final names though (naming isn't my strong side).
> > >
> > > AP_CFG_MERGE
> > > AP_CFG_MERGE_ARRAY
> >
> > Don't do that. That is just Ralf's coding style. It is not proof that we need
>this
> > in every single core module.
>
> HUH? The point is that even subversion uses such helpers for clarity. It would
> help all authors to offer these, consistently.
>
> We've (collectively) proven that config merge errors are simple to author, and
> difficult to debug.
And the SVN merge macros came from mod_dav. The only reason mod_dav_fs
doesn't have a similar macro is that it only has a single item to merge, so
I just spelled it out.
So you could say that I'm hitting 3 for 3 with using that INHERIT_VALUE
macro, and would appreciate a core version of it.
AP_CFG_MERGE_* located in http_config.h would make some sense to me.
In the mod_ssl version, there was the "unset" param; I would suggest the
simplest for assumes NULL. A second one would take an "unset" param.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
