On Mon, 10 Sep 2001, Ryan Bloom wrote:
>
> > > /* this will typically exit on the first test */
> > > for (f = r->output_filters; f != NULL; f = f->next)
> > > if (strcasecmp("OLD_WRITE", f->frec->name) == 0)
> > > break;
> > >
> > > i'm puking. strcasecmp???? strings??
> >
> > Yah :-) It could be optimized by recording a flag in the request_rec,
> > stating that the filter was inserted (rather than looking for it). The
> > strcasecmp() shouldn't be necessary because we uppercase f->frec->name
> > nowadays.
> >
> > Not that it will improve things overall, but there ya go. :-)
>
> This could actually be improved even more, by just checking for the actual
> pointer. f->frec is actually a global filter_rec, that we could easily assign to
> a global variable when the filter is registered. Then, that strcasecmp becomes
>
> if (f->frec == old_write_filter_rec)
>
> That could actually be a pretty big improvement, because we remove all string
> comparisons.
that'd be much better :)
-dean
