On Sat, 15 Sep 2001, Ian Holsman wrote:
> * functions should be static
Oops, I meant to fix those.
> * why are you defining your own strncmp??
I had the same question. strncmp, strnicmp, strcpy, strcat, strlen are
all reimplemented, plus "stringcontains" (strstr) and "strendswith". I
commented on this in the code... I have no idea why they are
reimplemented here. Kevin? Comments?
> * Caching should be removed (there is another caching module there
> it should use that), failing that, maybe it should be split out to
> a different filter
> * logging should be via the logging optional function
> * flushing should probably flush the zlib buffer before sending it out
> * only check if gzip is on ONCE per request. (ie if (!f->ctx)) and if
> you don't want it enabled remove it from the filter chain.
> * remove the de-chunking, you won't see this anyway
> * remove the 'enable' flag. if the user has setoutputfilter'd it he wants it
> * the filter should be a HTTP_HEADER not a content one.
> * the filter should only be run on a 'main' request (do you check this?)
> otherwise you will have a gzip'ed included file in a non-gziped main file.
All good points.
Thanks,
Cliff
--------------------------------------------------------------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
