On Thursday 04 October 2001 01:14 pm, Justin Erenkrantz wrote:
> > ctx->state = BODY_CHUNK;
> > ctx->remaining = get_chunk_size(line);
> >
> > - if (!ctx->remaining)
> > - {
> > + if (ctx->remaining <= 0) {
>
> No. =) Java weenie.
Huh? How is this him being a Java weenie? Aaron has changed a check
for !0 to a check for negative or 0. Those two checks are not equivalent.
I'm not sure if this is a valid change or not yet, but I am wondering what the
comment is about.
> > - if (ctx->state != BODY_NONE)
> > + if (ctx->state != BODY_NONE) {
>
> No need for braces here...
Braces are good programming style, whether they are needed or not.
It makes it far less likely that somebody will forget to add them later when
they are necessary.
Ryan
______________________________________________________________
Ryan Bloom [EMAIL PROTECTED]
Covalent Technologies [EMAIL PROTECTED]
--------------------------------------------------------------
