On Thu, Oct 04, 2001 at 10:01:37PM -0700, Justin Erenkrantz wrote: >... > On Thu, Oct 04, 2001 at 09:37:51PM -0700, Ian Holsman wrote: > > how about we back out the filter changes so that the rest of the > > server isn't broken. > > I'd rather not see us back this change out. But, it is your > prerogrative to veto it. I believe we need to chase this > problem down and fix all of the filters.
Agreed. We have taken a large step forwards. Very large, thanks to Justin. I identified these problems back in April or so, but never got the time to carry them through (I started to make some changes once, but for various reasons a good chunk was backed out). Thankfully, Justin found the time and inclination. To back these out now would just return us to the broken state we were in before. Things *happened* to work because we'd hacked stuff up enough to make it work. But the code was *wrong*. Why should we revert to something that we know is wrong? If we want mod_ssl or mod_proxy to work, then we can fix them. They *are* broken, if they have made improper assumptions. But breaking the core to solve their problems is not the right answer. Backing it out and waiting for a complete patch isn't possible either. That would be a huge and complex patch. It would not be reviewable, so we'd just end up applying it without any real review. And hoping for the best... With Justin's patch, we were able to review it, verify that it was a proper step forward, and get it checked in. There were a couple additional patches that he made, based on that review (suggestions from Ryan and myself). The *next* step is to complete the propagation of fixes throughout the code base. >... > Basically, these changes can only go as fast as the people > helping out. And, there's only one of me. =) -- justin Well said. I can happily contribute knowledge, but am so backed up on various projects that helping with coding just falls further and further behind. (sigh) Cheers, -g -- Greg Stein, http://www.lyra.org/
