On Sunday 25 November 2001 10:51 pm, Doug MacEachern wrote: > On Sat, 24 Nov 2001, Cliff Woolley wrote: > > Actually, that's not exactly true. If APR_HAS_MMAP, and the file bucket > > is between MMAP_THRESHOLD and MMAP_LIMIT (MMAP_LIMIT is 4MB by default), > > then yes, len will be up to 4MB. But if the file bucket is bigger than > > 4MB or the system doesn't have MMAP, then len will *never* be bigger than > > APR_BUCKET_BUFF_SIZE (8KB). > > hmm..putting ssl aside, lets say we have a 10Mb file, looking at > apr_buckets_file.c:file_read() that's ~1200 calls each to: > - malloc for the 8k buffer > - seek() for the current offset > - read() of 8k for the actual buffer > > not to mention the APR_BRIGADE_FOREACH loop and whatever else is in > between. seems that could use some performance tuning of its own?
But, that will only happen if we are modifying the contents. I think the best we could probably do is get rid of the seek call, and if we change the read API, the malloc. Ryan ______________________________________________________________ Ryan Bloom [EMAIL PROTECTED] Covalent Technologies [EMAIL PROTECTED] --------------------------------------------------------------
