[PATCH] log error when unable to note auth failure

[sterling]

hi -
When AuthType is not set, but Requirements are - apache gracefully fails
to note the auth failure (since its dependent on the AuthType).  This
patch adds that error logging in.


sterling

Index: server//protocol.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/server/protocol.c,v
retrieving revision 1.54
diff -u -r1.54 protocol.c
--- server//protocol.c  2001/11/21 03:46:22     1.54
+++ server//protocol.c  2001/11/27 23:55:50
@@ -761,9 +761,10 @@
         else if (!strcasecmp(type, "Digest"))
             ap_note_digest_auth_failure(r);
     }
-    /* XXX: else there is no AuthType configured
-     *      should we log an error or something ?
-     */
+    else {
+        ap_log_rerror(APLOG_MARK, APLOG_NOERRNO|APLOG_ERR,
+                      0, r, "need AuthType to note auth failure: %s", r->uri);
+    }
 }

 AP_DECLARE(void) ap_note_basic_auth_failure(request_rec *r)