On Fri, Jan 11, 2002 at 09:03:36AM -0500, Jeff Trawick wrote: > With current CVS code, prefork, APR_POOL_DEBUG, Linux, and > ElectricFence I readily hit a segfault on the APR_BRIGADE_NORMALIZE() > call in core input filter. It segfaulted because the brigade was > empty. With the following patch I can't seem to hit a segfault > anymore. > > Perhaps the brigade shouldn't be empty for some reason...
If the brigade in core_input_filter is empty, it means that the socket (and its bucket) has disappeared on us. Most likely, someone isn't paying attention to APR_EOF return values. We should return an error or at the very least APR_EOF if we see an empty brigade there. But, it would be more useful to find out which input filter isn't paying attention. -- justin
