Justin Erenkrantz wrote: >On Sun, Jan 27, 2002 at 07:30:03AM -0000, [EMAIL PROTECTED] wrote: > >>brianp 02/01/26 23:30:03 >> >> Modified: server protocol.c >> Log: >> Fixed a read from a deleted brigade in the new version of >> ap_rgetline()... >> >> In the "folding" case, there was an ap_get_brigade() call after >> the brigade had been destroyed. I noticed this while debugging >> a memory leak that showed up while testing the httpd with ab. >> > >Nice catch. =) What would you think about just calling >apr_brigade_create() again for the fold case? That would >simplify the exit paths again. -- justin >
That definitely would be less messy than an apr_brigade_destroy() before each return statement. My only concern is whether recreating the brigade would negatively affect performance. But if you can get the same speed with that approach, I'm +1 on using it. --Brian
