From: "Justin Erenkrantz" <[EMAIL PROTECTED]> Sent: Wednesday, February 06, 2002 3:54 PM
> Anyone have any details on: > > * mod_autoindex displays the wrong icon for subdirectories on Unix > > I'd like to see it fixed in 2.0.32, but I don't know the > details. -- justin mod_dir is now a fixup. Ergo the ap_process_request_internal will take a DIR dirent, passed to ap_sub_req_lookup_dirent(), and transform it to the actual resource that would be served. So if a module used the SSI include virtual="/manual/", it would include the /manual/index.html body. That causes problems for mod_autoindex, alone. mod_autoindex looks at the subrequest's result - not to determine it's content - but to decide it is a directory. That's [sort of] lame - and I patched the server to test the original dirent.filetype instead for the icon test. Greg reverted to rr->finfo.filetype, since dirent.filetype wasn't set on unix. He commented that he wants to avoid a stat. If you look at the dir_walk code, we now -skip- the stat if the r->finfo is already set. That means we -can- completely stat the dirent and we won't repeat the stat later. The simple patch is to change APR_FINFO_DIR (_READDIR? I don't recall) into APR_FINFO_MIN | APR_FINFO_NAME in the apr_dir_read call. And change again back to testing the dirent.filetype to decide if we have a dir. Bill
