From: "Justin Erenkrantz" <[EMAIL PROTECTED]>
Sent: Monday, February 18, 2002 12:55 AM


> This adds AddOutputFilterByType directive.  In our mod_deflate
> conversations, I think we kept coming back to this as a real
> good idea.

The idea is good.

> I think this patch is fine in and of itself, 

-1.  It requires the user to install mod_mime.  mod_mime handles mime types
for files, if the server is filesystem-less (a distinct possibility in 2.1 and
beyond, even in 2.0 for that matter, but not trivial) then they lose this legit
directive.

Please make this a core directive, as I've already moved SetHandler and the
Set{Input|Output}Filter directives.  No sense in populating more cruft in the
wrong module.

> but it doesn't work as
> expected due to the mod_dir/mod_negotiation showstopper (yeah, it's a
> showstopper for the next release).  
>
> I've got some hacky code that
> fixes up ap_internal_fast_redirect() to propogate the filters on a
> redirect.  But, it just showcases how badly broken fast_redirect is,
> so I'd rather we just toss it.  -- justin

A definate bug, and as I raised in status, a distinct possibility :)

The only problem with -removing- it altogether is that the internal redirect
must occur by the end of the fixup()s chain or we don't know what we are about
to serve after ap_process_request, prior to ap_run_request.

Bill

Reply via email to