On Tue, Mar 05, 2002 at 10:02:55AM +0100, Sander Striker wrote: > Hi, > > Below a patch to apr and a patch to httpd > to factor out the allocator from pools. It > is only the first cut, so crucial details > like documentation are missing. > > I'd like some feedback on the general idea > though. > > Hopefully this helps when implementing the > bucket allocator.
+1. I like the API. Brian's suggestion is goodness, but shouldn't stop this from going in. Two slight implementation problems: - apr_thread_mutex.h is now a dependency of apr_allocator.h. That means it can't use APR_POOL_DECLARE_ACCESSOR since apr_pools.h requires this file. So, I just expanded the declaration in apr_thread_mutex.h. I'll leave it up to you how to resolve this (either expand it there or move the DECLARE macro somewhere else). I think if we put a big XXX in that file and expand it, we should be okay for now. (Perhaps with a note near the POOL_DECLARE definition that apr_thread_mutex.h is a special exception.) - I think APR_POOL_DEBUG isn't working. Namely the apr_pool_create_ex prototype is wrong. And, I think the API is fine considering that this gives the bucket code a chance to use it. So, please commit at your earliest chance. =) -- justin
