"Bill Stoddard" <[EMAIL PROTECTED]> writes: > Introduces ap_rset_content_type()... This patch is not complete, I have not finished > reviewing it (or doing the doc), but it should demonstrate Ryan and Sander's >suggestion > for inserting resource filters based on content type. I am a bit concerned about some > crufty code paths inserting the same filter multiple times into the same output >stream.
What happens if a would-be generator calls ap_rset_content_type() but ends up declining? We get a bogus filter on the chain, right? What hooks are allowed to set r->content_type today? What hooks would be allowed to call ap_rset_content_type()? If something calls this other than a filter or the one hook that is really going to generate the content then the filter chain isn't correct. Is there a cheap way to do a check in ap_pass_brigade() to see if the content-type changed from the last time we checked? (but I guess ap_pass_brigade() isn't supposed to know this information) -- Jeff Trawick | [EMAIL PROTECTED] Born in Roswell... married an alien...
