> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Sent: 22 March 2002 21:37
> trawick 02/03/22 12:37:04
>
> Modified: modules/http http_protocol.c
> Log:
> add an extra level of parentheses to say "yes I know what I'm
> doing with that single '='" and more importantly to quiet a
> gcc -Wall warning
>
> Revision Changes Path
> 1.401 +1 -1 httpd-2.0/modules/http/http_protocol.c
>
> Index: http_protocol.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/http/http_protocol.c,v
> retrieving revision 1.400
> retrieving revision 1.401
> diff -u -r1.400 -r1.401
> --- http_protocol.c 22 Mar 2002 18:34:46 -0000 1.400
> +++ http_protocol.c 22 Mar 2002 20:37:04 -0000 1.401
> @@ -1030,7 +1030,7 @@
>
> /* keep a previously set server header (possibly from proxy), otherwise
> * generate a new server header */
> - if (server = apr_table_get(r->headers_out, "Server")) {
> + if ((server = apr_table_get(r->headers_out, "Server"))) {
> form_header_field(&h, "Server", server);
> }
> else {
Please put the comment in the code or make it explicit that you are
testing for != 0. The extra braces are bound to be removed by some
overactive style nitter ;)
Sander
