The last several changes should resolve a series of fairly random segfaults that have been observed at shutdown by Covalent's QA group [I was even able to reproduce in 'console' mode.] Although I'd love another pair of eyes on these latest changes, I'll include them in the .34 release so we don't waste time closing the ensuing bugzilla reports.
Bill >wrowe 02/04/04 15:36:45 > > Modified: server/mpm/winnt mpm_winnt.c > Log: > Uhmmm... notices only when we are running as a service [I hate strcmp.] > > Revision Changes Path > 1.259 +1 -1 httpd-2.0/server/mpm/winnt/mpm_winnt.c > > Index: mpm_winnt.c > =================================================================== > RCS file: /home/cvs/httpd-2.0/server/mpm/winnt/mpm_winnt.c,v > retrieving revision 1.258 > retrieving revision 1.259 > diff -u -r1.258 -r1.259 > --- mpm_winnt.c 4 Apr 2002 23:35:11 -0000 1.258 > +++ mpm_winnt.c 4 Apr 2002 23:36:45 -0000 1.259 > @@ -1850,7 +1850,7 @@ > * child a bit of time to exit gracefully. If the time expires, > * the child will be wacked. > */ > - if (strcasecmp(signal_arg, "runservice")) { > + if (!strcasecmp(signal_arg, "runservice")) { > mpm_service_stopping(); > } > /* Signal the child processes to exit */ > > >