On Tue, 9 Apr 2002, Ryan Bloom wrote: > Just commit it. If it doesn't work it will get fixed, but at least it > will continue to compile in the mean-time.
That was the approach I took with the bucket API change, and it bit me in the ass because while yes, it compiled, it was imperfect and the memory leaks took the developers on those platforms by surprise. I'm starting to think it's better to just post the patch and force someone take an active look at it 'cause it won't compile if they don't. :( PS!!!! David, the bucket API changes to the BeOS MPM still need review! I think I got the BeOS one a litte bit more right than the Win32 and Netware ones, but it was a shot in the dark at best. --Cliff
