On Fri, Apr 12, 2002 at 02:55:33PM -0700, Ryan Bloom wrote: > it 11 times in the server code itself. If the API is so broken that it > is unusable, why is it that the server is still using it?
Precisely because people haven't gotten around to it. Just because we went GA doesn't mean that the server is perfect. There are lots of APIs that we could optimize or enhance. I am merely pointing out that I think this is an API that we would be better off living without. In retrospect, I should have removed these functions while I was cleaning up the input filtering. This would have brought this issue up sooner, but now that we are GA, this API can't be changed. > it now. The function works, and it is widely used in ALL existing > content-generating modules. Forcing a new API just to force a new API > makes no sense, and shows no respect for module authors. I believe the breakage that Aaron is seeing is because that API is fundamentally broken. If you wish to cling to the 1.3 API, fine with me. I think we will end up hurting ourselves by trying to stick with the old APIs forever. Our entire server is built around buckets and brigades - trying to isolate the modules from them seems to me like a lost cause. I now don't care what you end up doing, but Aaron's patch is not the right solution. If you wish to come up with a solution that maintains the old API, go ahead. My only caveat will be that you can not break the filters in the process. I believe it must be permissible for a module to rely on the filters to enforce HTTP compliance not a 1.3-compatible API that doesn't understand buckets and brigades. -- justin
