Re: cvs commit: httpd-2.0/modules/metadata mod_setenvif.c

[Brian Pane]

[EMAIL PROTECTED] wrote:

>  -        if (b->pattern ? apr_strmatch(b->pattern, val, val_len) :
>  +        if ((b->pattern && apr_strmatch(b->pattern, val, val_len)) ||
>               !ap_regexec(b->preg, val, 0, NULL, 0)) {
>

Those two expressions aren't equivalent.  If b->pattern is nonzero
but the apr_strmatch fails, the "||" version will fall through into
the ap_regexec--which will segfault because the regex is going to be
null if b->pattern is non-null.

--Brian