> From: [EMAIL PROTECTED] [mailto:trawick@rdu88-251- > 253.nc.rr.com] On Behalf Of Jeff Trawick > > mod_ssl uses ssl_log(), which doesn't allow the caller to pass in > apr_status_t. Should we add a new parameter for that, or should we > add a separate function like ssl_log_error() with such a parameter? > > I'd vote for adding a new parm to ssl_log() right after the 2nd > parameter (and yes, I'll make the changes to the many callers :) ). > > Also, the existing accesses to errno in ssl_log() should be yanked, or > perhaps replaced with appropriate logic to handle whether or not an > apr_status_t was passed in. > > Comments?
Fix the ssl_log API so that it accepts the apr_status_t. This is one of the problems with having modules that use their own logs to store error information. When the core API changes to log more information, the module's logic tends to lag behind. If you wanted to change all ssl_log calls to ap_log_[r]error, I would be +1 for that too. Ryan
