At 11:30 AM 5/24/2002, you wrote: > > I presume the -k patch... since > > > > apache -k start -n apache2 > > > > dumps the usage message. Forget about a Monday tag, folks. > > Late in the week, perhaps? > >Bill, before you run off, what is the ConfigArgs registry key about?
Not going anywhere, overwhelmed with this weeks work-work which will end up throwing away my holiday weekend. Sorry if I didn't come across very friendly-like. On Windows, our command line argument is nothing but -k runservice. Not very interesting. We maintain our list of command line arguments in a registry key of type REG_MULTI_SZ, meaning each 'arg' is a null terminated part of the list of args [the end being double-null terminated, although since the entire char[] has a known length, it's redundant.] So -d is one argument, "c:\Apache2" is the next arg, etc, and they look like this; "-d\0c:\\Apache2\0-f\0c:\\Apache2\\conf\\httpd.conf\0" Or some such. Every time we use -k config we modify that array. When the SCM starts, we read and use those args, plus any arguments that were passed to the StartService() call (such as typing them in the 'optional parameters' field on the service property page, and clicking start.) > > There are four other boffo bugs I'd like to have a chance to look at before > > inflicting .37 on the world: > > > > 1. Fix apr_file_read() so that we don't crash on the first read in > rotatelogs. > > Win32's implementation appears to have been borked in overeagerness > > to work around unusual read cases - we can't handle the simple ones. > > > > 2. Fix WinNT MPM to use apr_thread_create/apr_proc_create. The former > > is a simple fix, the later is required for folks who install Apache to > > a non- > > ASCII file path or who pass non-ASCII arguments on the command line. > > It's the last I18N hassle in Apache2. Essentially, I'm getting > sick of us > > not eating our own dogfood ... those MS munchies may taste better, but > > where does it leave us? > >This is not a release show stopper For non-US directory names, it is. But I won't hold up .37 over this... although I'm likely to fix that code before attacking any issue except for 1. It would be part of the obvious fix for 3 as well... > > 3. Fix thread setup/teardown on winnt mpm. We are using non-threadsafe > > threadcount incr/dec operations. I've seen it deadlock with six > 'running > > threads' when no threads were left, and while it might be a quirk, we > > really need to address it. > >Looks easy enough to fix. I'll do it now. I have never seen a problem with >the code as it >is (though I agree it is not correct as is.) How do you recreate this? In the devstudio 7.0 environment. As I say, I've tripped over it once after running httpd at least 4,000 times this week in new module development. It's a very small race. apr_thread_join would eliminate the bug entirely, c.f. number 2. > > 4. Cruft in apr-util that exports undecorated names from apr_strmatch. 5. I forgot a biggy on Allen's and other folks' lists - FIX the CWD! That's trickier in that we need to change CWD every time we hit a ServerRoot directive to do this right. I'll simply wrap that in an #ifdef WIN32 and we can wage the rest of this battle later, since noone in the Unix world sees a benefit in changing the cwd. I can't imagine that OS2 wouldn't benefit from the same behavior, though. Bill
