Justin Erenkrantz wrote: > > Since my naming skills aren't that good, I'd like some people to > review this name change before committing.
The names are fine IMO. I've reviewed the entire patch...looks good! > I also haven't tested it yet, but I don't expect any problems. I've tested it. log replay runs correctly with the patch on my ThinkPad, so it should work on daedalus too. Without the patch, I could make ap_discard_request_body fail to do its job; with the patch, a_d_r_b works as expected. > I believe that this requires a MMN bump since we're chaning a core > structure around. yeah, but it's the Right Thing. The enum makes it a *lot* easier to see how to use c->keepalive correctly. Greg
