Cliff Woolley wrote:

>On 5 Sep 2002 [EMAIL PROTECTED] wrote:
>
>  
>
>>       bb = apr_brigade_create(r->pool, r->connection->bucket_alloc);
>>  +    if (bb == NULL) {
>>  +        r->connection->keepalive = AP_CONN_CLOSE;
>>  +        return -1;
>>  +    }
>>    
>>
>
>apr_brigade_create() will never return NULL.  This bit is unnecessary.
>  
>

That's not guaranteed.  The API, as currently documented, only
guarantees that it will return an apr_bucket_brigade*, not that
it will be non-null.

Brian


Reply via email to