Folks, this looks wrong after consideration. If someone is familiar with the Linux gcc optimizer, please see my last comments in
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14147 I'm starting to feel like the optimizer bit us. Bill At 09:27 PM 10/31/2002, [EMAIL PROTECTED] wrote: >wrowe 2002/10/31 19:27:20 > > Modified: server request.c > Log: > Fix a trailing slash/last filename truncation bug observed on Linux, > which affected DAV MOVE operations and even general file access. > PR 14147, 10687, 10236 [Dan Good <[EMAIL PROTECTED]>] > > I'm accepting Jeff Trawick's suggestion of twisting the test into an > assert, since it seems very unlikely (after correctly resetting the flag) > that this will fault. > > Reviewed by: Jeff Trawick, Will Rowe > > Revision Changes Path > 1.118 +2 -0 httpd-2.0/server/request.c > > Index: request.c > =================================================================== > RCS file: /home/cvs/httpd-2.0/server/request.c,v > retrieving revision 1.117 > retrieving revision 1.118 > diff -u -r1.117 -r1.118 > --- request.c 25 Oct 2002 16:38:11 -0000 1.117 > +++ request.c 1 Nov 2002 03:27:20 -0000 1.118 > @@ -924,6 +924,8 @@ > /* That temporary trailing slash was useful, now drop it. > */ > if (temp_slash) { > + temp_slash = 0; > + AP_ASSERT(r->filename[filename_len-1] == '/'); > r->filename[--filename_len] = '\0'; > } > > > >
