On 14 Nov 2002 [EMAIL PROTECTED] wrote: > Index: modules/filters/mod_deflate.c > =================================================================== > RCS file: /home/cvs/httpd-2.0/modules/filters/mod_deflate.c,v > retrieving revision 1.25 > diff -u -r1.25 mod_deflate.c > --- modules/filters/mod_deflate.c 10 Nov 2002 06:09:20 -0000 1.25 > +++ modules/filters/mod_deflate.c 14 Nov 2002 13:52:36 -0000 > @@ -510,7 +510,7 @@ > } > } > > - apr_brigade_destroy(bb); > + apr_brigade_cleanup(bb); > return APR_SUCCESS; > }
Yep, looks right to me. Saw a few other little brigade buglets in there, though, in the form of discarded return codes: line 479: ap_pass_brigade() line 484: apr_bucket_read() If these return something other than APR_SUCCESS, the filter should pass that back to its caller. --Cliff
