This patch eliminates the hardcoded charset table.  Instead it reads the charset 
table from a conf file.  The directive AuthLDAPCharsetConfig allows the admin to 
specify the charset conf file.  Is there also a need to specify additional conversions 
directly in the httpd.conf file through a different directive?  It seems that the 
charset conf file would be sufficient.  If there are multiple charsets per language, 
these can be set by specifying the 5 character language ID rather than the 2 character 
ID similar to the example in the charset.conv file for chinese.

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> [EMAIL PROTECTED] Tuesday, December 10, 2002 1:38:48 PM >>>
* Brad Nicholes wrote:

> Second cut at allowing extended characters.  The name of the directive
> changed to "AuthLDAPCharsetConversion" rather than
> "AuthLDAPConvertFromLanguage" since it is mainly dealing with character
> sets rather than languages.  It also changed from an AP_INIT_TAKE1 to and
> AP_INIT_TAKE12 to allow for an optional "to" character set rather than
> assuming "utf8".  If no "to" character set is given then it will default to
> "utf8".  Also the output buffer for the conversion to UTF8 is larger.

Sorry Brad, I really understand the main problem, but again: the hardcoded 
language/charset assignments are bad. There should be the possibility for 
the admin to assign it by himself. For example, there are several 
possibilities to use a charset for cyrillic characters. The (apache) docs 
use koi8-r and not iso-8859-5, for instance. I think, this could be a 
directive like "LDAPAssignLanguageCharset lang charset" (perhaps not so 
long name) or an external file similar to mod_mime's TypesConfig.

Otherwise my opinion is: mod_auth_ldap is experimental ;-) It's worth to 
try out and see what results and problems are coming further.

nd
-- 
Treat your password like your toothbrush. Don't let anybody else
use it, and get a new one every six months.  -- Clifford Stoll

                                    (found in ssl_engine_pphrase.c)

Attachment: mod_auth_ldap.c.patch
Description: Binary data

Attachment: charset.conv
Description: Binary data

Reply via email to