Re: cvs commit: httpd-2.0/server Makefile.in

[Ben Laurie]

[EMAIL PROTECTED] wrote:

jerenkrantz 2002/12/11 13:09:16

Modified: server Makefile.in
Log:
Take a stab at fixing the brokenness in our tree (grr!).
ls -1 is bound to be more portable than find -maxdepth, but I suspect it may
not be as portable as it really should.

man ls says "By default, ls lists one entry per line to standard output; the exceptions are to terminals or when the -C option is specified."

AFAIK, this completely standard behaviour.

You shouldn't need the -1.

Also, can I offer, should you be completely paranoid:

echo $$dir/*.h | sed 's/ /\
/g'

Cheers,

Ben.

Revision Changes Path
1.80 +1 -1 httpd-2.0/server/Makefile.in
Index: Makefile.in
===================================================================
RCS file: /home/cvs/httpd-2.0/server/Makefile.in,v
retrieving revision 1.79
retrieving revision 1.80
diff -u -u -r1.79 -r1.80
--- Makefile.in 3 Dec 2002 09:47:11 -0000 1.79
+++ Makefile.in 11 Dec 2002 21:09:16 -0000 1.80
@@ -47,7 +47,7 @@
tmp=export_files_unsorted.txt; \
rm -f $$tmp && touch $$tmp; \
for dir in $(EXPORT_DIRS); do \
- find $$dir -maxdepth 1 -type f -name '*.h' >> $$tmp; \
+ ls -1 $$dir/*.h >> $$tmp; \
done; \
sort -u $$tmp > $@; \
rm -f $$tmp

--
http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff