William A. Rowe, Jr. wrote:
forget it.I'm very close to an outright veto of such a change, at this time...
Not only is the binary interface to sendfile broken now, the source interface is broken too. Since there was no mmn bump, there is no reasonable way a module which ships independently from the core can write code to enable sendfile with the new interface and expect the module to compile against 2.0.43 or earlier.
I like the concept of disabling sendfile at runtime to handle the corner cases like nfs and broken OSes. No argument there. But the existing code goes beyond that. As things stand now, non-core module owners are screwed if they want to use sendfile in the majority of cases where it works fine.
Greg
