Graham Leggett wrote:
Brad Nicholes wrote:> - Added a support framework (using #defines) for multiple vendor LDAP > SDKs. The framework currently supports the SDKs from Novell, NetScape, > OpenLDAP, and Microsoft. (Spent significant time testing compiling and > running with the various SDKs on Win32. However, ran into problems with > Microsoft's SDK. It GPFs when doing an ldap_set_option.) The purpose of LDAP support being in apr-util is so that machine specific and SDK specific issues can be addressed there. The #defines you mention should not be in mod_ldap, they should rather be in apr-util.
yes, I was hoping somebody would bring this up... everybody seems to be happy about the code, but doesn't this issue need to be resolved before committing?
