On Fri, 14 Feb 2003 [EMAIL PROTECTED] wrote:
> nd 2003/02/14 10:14:24
>
> Modified: modules/mappers mod_alias.c
> Log:
> extend the check for Alias overlappings. Now test also previous
> (Script)AliasMatch commands.
Cool feature. Gramatical nitpicking below.
> - if (!p->regexp && alias_matches(f, p->fake) > 0) {
> + if ( !p->regexp && alias_matches(f, p->fake) > 0
> + || p->regexp && !ap_regexec(p->regexp, f, 0, NULL, 0)) {
> ap_log_error(APLOG_MARK, APLOG_WARNING, 0, cmd->server,
> "The %s command in line %d will probably never "
I prefer to call them "directives" rather than "commands".
> - "match. Check previous %sAlias commands for "
> + "match. Check previous %sAlias%s commands for "
> "overlappings.", cmd->cmd->name,
"overlaps", rather than "overlappings".
Or better yet, perhaps,
"The %s directive at line %d will probably never match because it
overlaps an earlier %sAlias%s."
Joshua.
