Re: mod_expires is broken was Re: [VOTE]: Apache 2.0.46

[Bill Stoddard]

Jeff Trawick wrote:

Justin Erenkrantz wrote:

--On Tuesday, May 27, 2003 1:29 PM -0700 Justin Erenkrantz 
<[EMAIL PROTECTED]> wrote:


ExpiresDefault is busted.

The offending line is mod_expires.c:531.

t = apr_table_overlay(r->pool, notes->expfields, t);

apr_table_overlay may create a new table
always does, right?  (or the doc is wrong :) )

It shouldn't matter whether the Expires and Cache-Control fields are 
added to headers_out or err_headers_out at this point in the filter 
chain, so shouldn't this work as a replacement?

r->headers_out =
  apr_table_overlay(r->pool, notes->expfields, r->headers_out);
That looks right to me.

Bill