* Jeff Trawick wrote:
> [EMAIL PROTECTED] wrote:
>> nd 2003/08/06 07:46:48
>>
>> Modified: . CHANGES
>> modules/dav/main mod_dav.c
>> Log:
>> use bucket brigades directly when reading PUT data. This avoids
>> problems with content-length-modifying input filter (like deflate).
>
>> Index: mod_dav.c
>> ===================================================================
>> RCS file: /home/cvs/httpd-2.0/modules/dav/main/mod_dav.c,v
>> retrieving revision 1.97
>> retrieving revision 1.98
>> diff -u -r1.97 -r1.98
>> --- mod_dav.c 16 Jul 2003 06:31:53 -0000 1.97
>> +++ mod_dav.c 6 Aug 2003 14:46:48 -0000 1.98
>
>> @@ -984,39 +979,61 @@
> ...
>> + do {
>> + apr_status_t rc;
>> +
>> + rc = ap_get_brigade(r->input_filters, bb,
>> AP_MODE_READBYTES,
>> + APR_BLOCK_READ, DAV_READ_BLOCKSIZE);
>> +
>> + if (rc != APR_SUCCESS) {
>> + err = dav_new_error(r->pool,
>> HTTP_INTERNAL_SERVER_ERROR, 0,
>> + "Could not get next bucket
>> brigade");
>> + break;
>
> don't we need to set keepalive flag to AP_CONN_CLOSE here and for any
> other error that causes us to stop reading the request body?
I thought, ap_status_drops_connection solves this automatically (for these
error codes)?
nd
