+         nd replies: But if it can't be 0 the alternatives thereafter
make no
  +           sense anymore, right?

Good point, so if that is true then isn't the code in the else part of
ap_get_server_port() also wrong.  In other words, ap_default_port()
would never be called if UseCanonicalName is ON.

Brad 

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> [EMAIL PROTECTED] Friday, November 21, 2003 4:25:37 PM >>>
nd          2003/11/21 15:25:37

  Modified:    .        Tag: APACHE_2_0_BRANCH STATUS
  Log:
  vote & note
  
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.751.2.554 +4 -2      httpd-2.0/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/STATUS,v
  retrieving revision 1.751.2.553
  retrieving revision 1.751.2.554
  diff -u -u -r1.751.2.553 -r1.751.2.554
  --- STATUS    21 Nov 2003 22:38:42 -0000      1.751.2.553
  +++ STATUS    21 Nov 2003 23:25:37 -0000      1.751.2.554
  @@ -307,6 +307,8 @@
         bnicholes response: I couldn't tell you for sure if
local_addr->port
          could be 0.  But it makes sense that if it were then Apache 
          wouldn't be listening on any port so it wouldn't matter
anyway.
  +         nd replies: But if it can't be 0 the alternatives
thereafter make no
  +           sense anymore, right?
   
       * mod_status: Report total CPU time accurately when using a
         threaded MPM.  PR: 23795
  @@ -364,7 +366,7 @@
   
       * Fix display of empty variables via mod_include.  PR 24734.
           modules/metadata/mod_env.c r1.31
  -      +1: trawick
  +      +1: trawick, nd
   
   CURRENT RELEASE NOTES:
   
  
  
  

Reply via email to