On Thu, 20 Nov 2003 [EMAIL PROTECTED] wrote:
> stoddard 2003/11/20 11:44:19
>
> Modified: . CHANGES
> server/mpm/winnt child.c mpm.h
> Log:
> Win32: Make Win32 MPM transaction pools honor MaxMemFree
>
> /* Create the tranaction pool */
> - if ((rv = apr_pool_create(&context->ptrans, pchild)) !=
> APR_SUCCESS) {
> + apr_allocator_create(&allocator);
> + apr_allocator_max_free_set(allocator, ap_max_mem_free);
> + rv = apr_pool_create_ex(&context->ptrans, NULL, NULL, allocator);
> + if (rv != APR_SUCCESS) {
> ap_log_error(APLOG_MARK,APLOG_WARNING, rv, ap_server_conf,
> "mpm_get_completion_context: Failed to create
> the transaction pool.");
> CloseHandle(context->Overlapped.hEvent);
> return NULL;
> }
> - apr_pool_tag(context->ptrans, "ptrans");
> + apr_allocator_owner_set(allocator, context->ptrans);
> + apr_pool_tag(context->ptrans, "transaction");
This seems reasonable. +1 (untested). One question, though. Why is
ptrans no longer a child pool of pchild?
--Cliff
