* Ben Laurie <[EMAIL PROTECTED]> wrote:

> >   -    char errstr[MAX_STRING_LEN];
> >   +    char errstr[MAX_STRING_LEN], scratch[MAX_STRING_LEN];
> 
> Surely scratch and errstr should be MAX_STRING_LEN*4?

Hmm. MAX_STRING_LEN is 8k. So we put 16k onto the stack now. Would you
really like to mess up the stack with 64KB for error message stuff? At least
on threaded platforms this will fail.

> >   +                c2x(*s, d);
> 
> Am I being dim? Shouldn't this be c2x(*s,d+1)?

ehm, no?

nd

Reply via email to