Ben Laurie wrote:
Jeff Trawick wrote:
See http://www.apache.org/~trawick/exception_hook_13.html
You should make the logged strings safe, like mod_log_forensic does, and I think the format should be compatible (which means no space after the colon).
Thanks for taking a look!
I removed the space after the colon, but at present am not too eager about the escaping of the strings.
Why not?
If for some reason the module would be seriously considered for committing to cvs, that is a different ballgame, of course. Same if for some other reason I get the idea that folks would actually use it.
What I'd really like to see happen is have the patch to core committed. If people are truly interested in having the module(s) put in experimental, that is cool too though I'm not sure I think that's such a good idea until/unless it is clear that it will be used by more than a handful of people (bloat).
Right - I think they would be great inclusions, though.
Anyway +1 (untested) for the core patch.
BTW, I changed the storage allocation of the "hook" record to use pconf and to clear the list via a cleanup registered on pconf (http://www.apache.org/~trawick/13_fatal_exception_patch).
Sounds good.
Cheers,
Ben.
-- http://www.apache-ssl.org/ben.html http://www.thebunker.net/
"There is no limit to what a man can do or how far he can go if he doesn't mind who gets the credit." - Robert Woodruff
