On Mon, Jan 26, 2004 at 04:55:34PM -0600, Ben Collins-Sussman wrote:
> On Fri, 2004-01-23 at 08:07, Joe Orton wrote:
> 
> > Nice, this is easy enough to reproduce.  It only fills up because the
> > httpd children all have the read end of the pipe open, which is a bug in
> > itself.  Applying below ensures that the pipe gets closed when the piped
> > logger exits, and so writes() fail with ETERM rather than blocking up in
> > the leftover children.
> 
> Yup, it fixes the immediate hanging-httpd problem, but then the httpd
> child is left unable to log *anything* after the 'graceful' for the
> remainder of the svn commit.  If the 'graceful' happens early on, you
> could potentially lose all logging for most of the commit.  It's not a
> real fix.

Yeah, that naive patch also broke reviving a piped logger which dies
unexpectedly, and probably more.  Please do file a bug on this issue.

joe

Reply via email to