On Wed, Feb 25, 2004 at 05:12:33PM -0800, Mathihalli, Madhusudan wrote:
> More feedback incorporated !

ap_flush_conn can just use a single brigade with two buckets, no extra
variables needed there, also needs s/APU_DECLARE/AP_DECLARE in
eoc_bucket.c, and perhaps the prototypes are more appropriate in
http_connection.h but it's pretty arbitrary with the error_bucket in
http_protocol.h already.

> +            filter_ctx->nobuffer = 1;
> +            status = ssl_filter_io_shutdown(filter_ctx, f->c, 0);
> +            if ((status = ap_pass_brigade(f->next, bb)) != APR_SUCCESS) {

should either do something with the return value of io_shutdown or not
assign it to status.

Nearly there ;)

joe

Reply via email to